Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type): add support for double precision #153

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

crwen
Copy link
Member

@crwen crwen commented Mar 9, 2024

What problem does this PR solve?

Add support for double precision LogicalType. This is the same to double or float(8)

Issue link: #130

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Mar 10, 2024
@KKould KKould self-requested a review March 10, 2024 10:37
@KKould
Copy link
Member

KKould commented Mar 10, 2024

I think this PR has fully implemented this feature, but it seems that since Double and DoublePrecision types are highly consistent, then we only support LogicType::Double and use TryFrom<sqlparser::ast::DataType> for LogicalType
code_url Is converting DoublePrecision to Double a simpler and lower maintenance option?

@KKould KKould mentioned this pull request Mar 10, 2024
51 tasks
@crwen
Copy link
Member Author

crwen commented Mar 10, 2024

But when using DESCRIBE table, the type of double precision will be Double but not DoublePrecision. Is it OK to do so?

@KKould
Copy link
Member

KKould commented Mar 10, 2024

But when using DESCRIBE table, the type of double precision will be Double but not DoublePrecision. Is it OK to do so?

I think it's okay

@KKould
Copy link
Member

KKould commented Mar 11, 2024

Thanks for your contribution.

@KKould KKould merged commit 735192d into KipData:main Mar 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants