Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor RangeDetacher #151

Merged
merged 1 commit into from
Mar 6, 2024
Merged

refactor RangeDetacher #151

merged 1 commit into from
Mar 6, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Mar 6, 2024

What problem does this PR solve?

use RangeDetacher for Range inference to reduce redundant logic and avoid more potential bugs

At the same time, RangeDetacher will traverse the ScalarExpression and process the constant relationships in it. It does not need to obtain all the constant relationships before extracting them, avoiding many unnecessary processing processes such as repeatedly creating Vec and sorting.

RangeDetacher has richer test cases than before to ensure correctness

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Mar 6, 2024
@KKould KKould added enhancement New feature or request invalid This doesn't seem right labels Mar 6, 2024
@KKould KKould merged commit bfa8a4b into KipData:main Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant