Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add where_by_index.slt to verify the correctness of IndexScan #148

Merged
merged 1 commit into from
Mar 1, 2024
Merged

test: add where_by_index.slt to verify the correctness of IndexScan #148

merged 1 commit into from
Mar 1, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Mar 1, 2024 •
edited
Loading

What problem does this PR solve?

In order to test whether DNF and CNF are correct in IndexScan, where_by_index.slt is added

feat

  • sqllogictest support specifying slt files for testing
    • e.g. cargo run --bin sqllogictest-test -- --path='tests/slt/where_by_index.slt'

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Mar 1, 2024
@KKould KKould added the test New test label Mar 1, 2024
@KKould KKould merged commit 4f44d62 into KipData:main Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KKould KKould

Labels
test New test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KKould