Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support if()/ifnull()/nullif()/coalesce()/case ... when ... #143

Merged
merged 1 commit into from
Feb 18, 2024
Merged

feat: support if()/ifnull()/nullif()/coalesce()/case ... when ... #143

merged 1 commit into from
Feb 18, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Feb 18, 2024

What problem does this PR solve?

  • support if()/ifnull()/nullif()/coalesce()/case ... when ...
  • add e2e test: crdb/condition.slt
  • fix when performing equivalent calculations between Null and Null, Null should be returned.

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added bug Something isn't working enhancement New feature or request labels Feb 18, 2024
@KKould KKould self-assigned this Feb 18, 2024
@KKould KKould merged commit 982bb61 into KipData:main Feb 18, 2024
3 checks passed
@KKould KKould mentioned this pull request Feb 19, 2024
Open
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KKould KKould

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KKould