New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cast numeric to boolean and `and/or` only has Null on one side #142

Merged

KKould merged 2 commits into KipData:main from KKould:main

Feb 17, 2024

Member

KKould commented Feb 17, 2024

What problem does this PR solve?

cast numeric to boolean
- SELECT NOT(1::boolean)
and/or only has Null on one side
- SELECT NULL AND false -> false

Code changes

Has Rust code change
Has CI related scripts change

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Note for reviewer


          fix: cast numeric to boolean and and/or only has Null on one side

7c0c0b6

KKould self-assigned this

KKould added the bug label


          code fmt

8c24c94

KKould merged commit 3907fcd into KipData:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug