Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DataType::Tuple #138

Merged
merged 1 commit into from
Feb 13, 2024
Merged

feat: add DataType::Tuple #138

merged 1 commit into from
Feb 13, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Feb 13, 2024

What problem does this PR solve?

select * from test where (x, 1) in ((1, 1), (1, 2))

+----+---+---+
| id | x | y |
+============+
| 0  | 1 | 1 |
|----+---+---|
| 2  | 1 | 1 |
+----+---+---+

select * from test where (x, 1) != (1, 1)

+----+---+---+
| id | x | y |
+============+
| 1  | 2 | 2 |
|----+---+---|
| 3  | 3 | 3 |
+----+---+---+

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Feb 13, 2024
@KKould KKould added the enhancement New feature or request label Feb 13, 2024
@KKould KKould merged commit d1d5202 into KipData:main Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant