Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize expression mapping #137

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Optimize expression mapping #137

merged 3 commits into from
Feb 12, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Feb 12, 2024

What problem does this PR solve?

  • feat: added NormalizationRuleImpl::ColumnRemapper to optimize expression mapping and avoid polling search
  • fix: duplicate ColumnIds between multiple tables may cause constant relationship extraction errors

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added the enhancement New feature or request label Feb 12, 2024
@KKould KKould self-assigned this Feb 12, 2024
@KKould KKould merged commit b6a3726 into KipData:main Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KKould KKould

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KKould