fix(binder): insert column count validation #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like omitting the padding of the default values is causing the e2e test to fail |
When column names are not specified, the length of values cannot exceed the number of columns of the table. When column names are specified, values need to be the same length to given column names.
😀Fixed, e2e tests now pass. |
|
Everything looks good, thank you very much for your contribution |
KKould
added
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add corresponding issue link with summary if exists -->
Issue link:
#110
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer