fix(binder): insert column count validation

KipData · Dec 18, 2023 · f62d3e2 · f62d3e2
1 parent 33a310c
commit f62d3e2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/binder/insert.rs b/src/binder/insert.rs
@@ -43,6 +43,12 @@ impl<'a, T: Transaction> Binder<'a, T> {
             }
             let mut rows = Vec::with_capacity(expr_rows.len());
             for expr_row in expr_rows {
+                if expr_row.len() != columns.len() {
+                    return Err(BindError::ColumnCountMismatch(
+                        columns.len(),
+                        expr_row.len(),
+                    ));
+                }
                 let mut row = Vec::with_capacity(expr_row.len());
 
                 for (i, expr) in expr_row.iter().enumerate() {

diff --git a/src/binder/mod.rs b/src/binder/mod.rs
@@ -219,6 +219,8 @@ pub enum BindError {
     InvalidColumn(String),
     #[error("ambiguous column {0}")]
     AmbiguousColumn(String),
+    #[error("column count not match, expect {0}, got {1}")]
+    ColumnCountMismatch(usize, usize),
     #[error("binary operator types mismatch: {0} != {1}")]
     BinaryOpTypeMismatch(String, String),
     #[error("subquery error: {0}")]