Skip to content

Commit

Permalink
fix CacheError (#99)
Browse files Browse the repository at this point in the history
* fix CacheError

* install protoc
  • Loading branch information
guojidan authored Nov 21, 2023
1 parent 43787a7 commit f333011
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
override: true
components: rustfmt, clippy

- name: Install Protoc
uses: arduino/setup-protoc@v2

# `cargo check` command here will use installed `nightly`
# as it is set as an "override" for current directory

Expand Down Expand Up @@ -75,6 +78,9 @@ jobs:
override: true
components: rustfmt, clippy

- name: Install Protoc
uses: arduino/setup-protoc@v2

# `cargo check` command here will use installed `nightly`
# as it is set as an "override" for current directory

Expand Down
10 changes: 0 additions & 10 deletions src/storage/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ use crate::storage::table_codec::TableCodec;
use crate::types::errors::TypeError;
use crate::types::index::{Index, IndexMetaRef};
use crate::types::tuple::{Tuple, TupleId};
use kip_db::error::CacheError;
use kip_db::kernel::lsm::mvcc;
use kip_db::KernelError;
use std::collections::VecDeque;
Expand Down Expand Up @@ -147,9 +146,6 @@ pub enum StorageError {
#[error("kipdb error")]
KipDBError(KernelError),

#[error("cache error")]
CacheError(CacheError),

#[error("type error")]
TypeError(#[from] TypeError),

Expand All @@ -168,9 +164,3 @@ impl From<KernelError> for StorageError {
StorageError::KipDBError(value)
}
}

impl From<CacheError> for StorageError {
fn from(value: CacheError) -> Self {
StorageError::CacheError(value)
}
}

0 comments on commit f333011

Please sign in to comment.