Fix duplicate cast in insert (#78)

KipData · Oct 5, 2023 · ce2d04c · ce2d04c
1 parent 0ad82e7
commit ce2d04c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -19,7 +19,7 @@ test command
 ```sql
 create table t1 (a int, b int);
 
-insert into t1 (a, b) values (1, 1), (5, 3), (5, 2);
+insert into t1 (a, b) values (1, 1), (5, 3), (6, 2);
 
 update t1 set a = 0 where b > 1;
 

diff --git a/src/binder/insert.rs b/src/binder/insert.rs
@@ -59,7 +59,9 @@ impl<S: Storage> Binder<S> {
                         }
                         ScalarExpression::Unary { expr, op, .. } => {
                             if let ScalarExpression::Constant(value) = expr.as_ref() {
-                                row.push(Arc::new(unary_op(value, op)?))
+                                row.push(Arc::new(
+                                    unary_op(value, op)?.cast(columns[i].datatype())?,
+                                ))
                             } else {
                                 unreachable!()
                             }

diff --git a/src/execution/executor/dml/insert.rs b/src/execution/executor/dml/insert.rs
@@ -63,10 +63,9 @@ impl Insert {
                 let mut tuple_map = HashMap::new();
                 for (i, value) in values.into_iter().enumerate() {
                     let col = &columns[i];
-                    let cast_val = DataValue::clone(&value).cast(&col.datatype())?;
 
                     if let Some(col_id) = col.id {
-                        tuple_map.insert(col_id, Arc::new(cast_val));
+                        tuple_map.insert(col_id, value);
                     }
                 }
                 let primary_col_id = primary_key_index.get_or_insert_with(|| {