-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] base_report_to_label_printer: Migration to 18.0 #1
base: 18.0
Are you sure you want to change the base?
Conversation
@api.model | ||
def _register_hook(self): | ||
super()._register_hook() | ||
self.SELF_WRITEABLE_FIELDS.extend(["default_label_printer_id"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should override SELF_READABLE_FIELDS
and SELF_WRITEABLE_FIELDS
property https://github.com/odoo/odoo/blob/09fa1db600c31d2d04f0504f0412cbbc85ff7e3d/odoo/addons/base/models/res_users.py#L351
comodel_name="printing.printer", string="Default Label Printer" | ||
) | ||
|
||
@api.model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@api.model |
no need override this method
btw, can you squash the commit in the next update? |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: report-print-send-16.0/report-print-send-16.0-base_report_to_label_printer Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-base_report_to_label_printer/
Currently translated at 100.0% (4 of 4 strings) Translation: report-print-send-16.0/report-print-send-16.0-base_report_to_label_printer Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-base_report_to_label_printer/it/
250269a
to
94219bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review)
|
dc3e56e
to
670a304
Compare
670a304
to
c9d8629
Compare
Depend on: [18.0][MIG] base_report_to_printer: Migration to 18.0