forked from doanduyhai/killrvideo-java
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 final #44
Open
clun
wants to merge
36
commits into
master
Choose a base branch
from
v2_final
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Branch with latest fixes
fixed syntax error
Fixed dockerfile to use killrvideo-java.jar
SonicDMG
reviewed
Mar 27, 2020
killrvideo-commons/src/main/java/com/killrvideo/conf/DseDriverConfiguration.java
Outdated
Show resolved
Hide resolved
SonicDMG
reviewed
Mar 27, 2020
killrvideo-commons/src/main/java/com/killrvideo/conf/KafkaConfiguration.java
Show resolved
Hide resolved
SonicDMG
reviewed
Mar 27, 2020
SonicDMG
previously approved these changes
Mar 27, 2020
Soften version requirements for web and dse-config services
HadesArchitect
previously approved these changes
Apr 1, 2020
HadesArchitect
previously approved these changes
Apr 2, 2020
Soften reqs for dse-config in CI
HadesArchitect
previously approved these changes
Apr 2, 2020
HadesArchitect
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cannot be automatically merged as few commits have been performed on master for dev days.
4.5.1
application.conf
but with retry and possible to override the filename for any deployment with an Environment Variable.