Add early return on UDP check if the socket is invalid.

Kilemonn · Jul 11, 2024 · 5bc9564 · 5bc9564
1 parent abf65e8
commit 5bc9564
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Environment-Test-Dockerfile b/Environment-Test-Dockerfile
@@ -26,13 +26,13 @@ COPY ./src ./src
 COPY ./tests ./tests
 COPY ./CMakeLists.txt ./CMakeLists.txt
 
-# Do a fake copy to make sure it runs both stages
-COPY --from=alpine /alpine/build/test/CppSocketLibraryTests /ubuntu/CppSocketLibraryTests
-
 RUN ["cmake", "-B", "build", "."]
 
 WORKDIR /ubuntu/build
 RUN ["make", "all"]
 
 WORKDIR /ubuntu/build/tests
 RUN ["./CppSocketLibraryTests"]
+
+# Do a fake copy to make sure it runs both stages
+COPY --from=alpine /alpine/build/tests/CppSocketLibraryTests /ubuntu/CppSocketLibraryTests
diff --git a/src/socket/UDPSocket.cpp b/src/socket/UDPSocket.cpp
@@ -225,9 +225,13 @@ namespace kt
 
     int UDPSocket::pollSocket(SOCKET socket, const long& timeout) const
 	{
+		if (kt::isInvalidSocket(socket))
+		{
+			return -1;
+		}
+
 		timeval timeOutVal{};
 		int res = kt::pollSocket(socket, timeout, &timeOutVal);
-
 		return res;
 	}