Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature Multi Select Month #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lillo42
Copy link

@lillo42 lillo42 commented Nov 24, 2016

Hi,

I have implement Multi Select Month,

I add 2 new properties.
MultiSelect: boolean
Separetor: string

if Multiselect is active, will accept select multi month and will put on input all month select separete by separetor.

@benjamin-albert
Copy link
Collaborator

Thanks for opening a pull request and helping make this plugin better for everyone!

I just fetched your changes and messed with the demo to take a look at the new feature.

Looks really nice!

As you can see from the Travis-CI Build some tests are failing (some things broke).

We need those tests to pass before we can merge.

So we have two options:

  1. You run the tests and fix them.

  2. We fetch your changes and fix the tests.

I personally learned a lot form writing tests for this project and I think you can learn a lot form this to.

If you you need any help running/updating the tests we wi'll be more than happy to help.

@lillo42
Copy link
Author

lillo42 commented Nov 25, 2016

Thank you :), as soon as I will run the test and fixed. And make some example how use,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants