Add Knight by Quaternius #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghgary
reviewed
Dec 2, 2024
|
|
||
| This is a version of [Knight by @Quaternius](https://quaternius.com/packs/knightcharacter.html) that has been modified to use child nodes with meshes parented to joints. The Knight character's body is a skinned mesh, but the helmet and the optional sword are separate meshes. The helmet is parented to a joint in the head, and the sword (which only appears in some of the available animations) is parented to a bone in the right hand. | ||
|
|
||
| If the helmet is missing or appears out of place, it may indicate the client implementation has not processed the parent/child hierarchy correctly including the set of joints in the parent. |
There was a problem hiding this comment.
I didn't realize initially that this model had multiple animations. If the first animation Run is chosen, there is no sword. I was confused for a bit. It might be worth mentioning the animations and what they are supposed to do somewhere in this doc. Or maybe reduce the animations to a single one that matches the screenshot and description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test model with a skinned mesh, and non-skinned meshes as children of the joints.