Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set cli11 folder property on CMake 3.19 and higher #971

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

jherico
Copy link
Contributor

@jherico jherico commented Mar 9, 2024

Description

Don't attempt to change the CLI11 target FOLDER property unless on CMake 3.19 and higher. Per this comment it's apparently problematic on older versions of CMake.

General Checklist:

Please ensure the following points are checked:

No code or project setting changes. This is purely CMake meta-project information.

  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

@SaschaWillems SaschaWillems self-requested a review March 10, 2024 10:38
Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR 👍🏻

@tomadamatkinson tomadamatkinson merged commit ef5959b into KhronosGroup:main Mar 10, 2024
25 checks passed
@jherico jherico deleted the fix/third_party branch March 12, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants