Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask to press return at the end of showing help on non-Windows platforms #957

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Don't ask to press return at the end of showing help on non-Windows platforms #957

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac50973
Don't ask to press return on Linux platforms
gary-sweet Feb 28, 2024
fc1ca2e
Just check for Windows platform instead
gary-sweet Feb 28, 2024
93263c3
Enclosed condition in ifdef
gary-sweet Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions framework/platform/platform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,14 +245,14 @@ void Platform::terminate(ExitCode code)

on_platform_close();

#ifdef PLATFORM__WINDOWS
// Halt on all unsuccessful exit codes unless ForceClose is in use
if (code != ExitCode::Success && !using_plugin<::plugins::ForceClose>())
{
#ifndef ANDROID
std::cout << "Press return to continue";
std::cin.get();
#endif
}
#endif
}

void Platform::close()
Expand Down
Loading