Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vkb::core::HPPDebug and derived classes from a facade over vkb::core::Debug to self-contained classes using vulkan.hpp #788

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Change vkb::core::HPPDebug and derived classes from a facade over vkb::core::Debug to self-contained classes using vulkan.hpp #788

merged 1 commit into from
Sep 11, 2023

Conversation

asuessenbach
Copy link
Contributor

Description

Includes a newer version of vulkan, where a mapping function from ObjectType to DebugReportObjectType is provided.

Builds on Win10 with VS2022. Runs on Win10 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering

@asuessenbach
Change vkb::core::HPPDebug and derived classes from a facade over vkb…
ef15c43 
…::core::Debug to self-contained classes using vulkan.hpp
@asuessenbach asuessenbach marked this pull request as ready for review August 30, 2023 14:41
@asuessenbach asuessenbach requested a review from a team August 30, 2023 14:41
@marty-johnson59 marty-johnson59 merged commit 15976fa into KhronosGroup:main Sep 11, 2023
23 checks passed
@asuessenbach asuessenbach deleted the HPPDebugUtils branch September 18, 2023 15:11
gary-sweet added a commit to gary-sweet/Vulkan-Samples that referenced this pull request Oct 20, 2023
@gary-sweet
Fix for crashes caused by hpp interface difference
d7e6021 
There is a difference in interfaces between DebugUtils and HPPDebugUtils introduced
by KhronosGroup#788

DebugUtils accepts the color argument as glm::vec4 const color whereas
HPPDebugUtils takes a reference instead. This ends up causing a color of
<0,0,0,0> being reinterpreted as a reference, which doesn't end well.

This change makes the HPPDebugUtils interface match DebugUtils again.
@gary-sweet gary-sweet mentioned this pull request Oct 24, 2023
Merged
12 tasks
marty-johnson59 pushed a commit that referenced this pull request Oct 27, 2023
@gary-sweet
Fix for crashes caused by hpp interface differences (#836)
66ddc4b 
* Fix for crashes caused by hpp interface difference

There is a difference in interfaces between DebugUtils and HPPDebugUtils introduced
by #788

DebugUtils accepts the color argument as glm::vec4 const color whereas
HPPDebugUtils takes a reference instead. This ends up causing a color of
<0,0,0,0> being reinterpreted as a reference, which doesn't end well.

This change makes the HPPDebugUtils interface match DebugUtils again.

* Fixed clang format

* Another clang format fix

* Yet another format fix

My local clang-format was too old to match what was expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary-sweet gary-sweet gary-sweet approved these changes

@SaschaWillems SaschaWillems SaschaWillems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asuessenbach @SaschaWillems @gary-sweet @marty-johnson59