Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored API sample hpp_terrain_tessellation. #779

Merged

Conversation

asuessenbach
Copy link
Contributor

Description

Besides the refactoring of the sample hpp_terrain_tessellation, this PR

  • extends the argument list of the function vkb::common::create_graphics_pipeline in the file common/hpp_vk_common.h;
  • adds an optional argument address_mode to the functions HPPApiVulkanSample::load_texture and HPPApiVulkanSample::load_texture_array.
  • includes the appropriate changes in the Vulkan-Hpp-based samples.

Builds on Win10 with VS2022. Runs on Win10 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering

@asuessenbach asuessenbach marked this pull request as ready for review August 16, 2023 15:55
@asuessenbach asuessenbach requested a review from a team August 16, 2023 15:55
Copy link
Contributor

@gary-sweet gary-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support tessellation, so I can't test that part, but everything else is ok.

@SaschaWillems SaschaWillems self-requested a review August 28, 2023 14:57
@marty-johnson59 marty-johnson59 merged commit ee05d72 into KhronosGroup:main Aug 28, 2023
23 checks passed
@asuessenbach asuessenbach deleted the hpp_terrain_tessellation branch August 29, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants