-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dynamic blending sample for VK_EXT_extended_dynamic_state3 #746
Conversation
87c4677
to
95307f7
Compare
Nice! |
I can't test this one unfortunately since we don't support dynamic ColorBlendAdvanced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this sample 👍
Runs fine for me. I only found a very small typo in the readme, so I'll give this an approval :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized, I didn't submit my review, yet!
Done now.
Add blend equadion extension support Add blend advanced extension support
ea42c99
to
a3558e4
Compare
a3558e4
to
e0941df
Compare
Description
This PR proposes the sample demonstrating dynamic blending functionality of the VK_EXT_extended_dynamic_state3 extension. Functions used are:
vkCmdSetColorBlendEnableEXT
,vkCmdSetColorBlendEquationEXT
,vkCmdSetColorBlendAdvancedEXT
,vkCmdSetColorWriteMaskEXT
.Notes
Tested on:
Ubuntu 23.04
Intel i7-11800H
Intel TigerLake-H GT1/Nvidia T600 Mobile
32 GB RAM
Arch Linux/Windows 11
AMD Ryzen 2600
Nvidia GTX 1070
16 GB RAM
This PR uses non-final version of the color edit implementation from my other PR. I intend to fix it when the status of the other PR is clarified.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: