Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dynamic blending sample for VK_EXT_extended_dynamic_state3 #746

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

Krzysztof-Dmitruk-Mobica
Copy link
Contributor

@Krzysztof-Dmitruk-Mobica Krzysztof-Dmitruk-Mobica commented Jul 10, 2023

Description

This PR proposes the sample demonstrating dynamic blending functionality of the VK_EXT_extended_dynamic_state3 extension. Functions used are: vkCmdSetColorBlendEnableEXT, vkCmdSetColorBlendEquationEXT, vkCmdSetColorBlendAdvancedEXT, vkCmdSetColorWriteMaskEXT.

Notes

Tested on:

Ubuntu 23.04
Intel i7-11800H
Intel TigerLake-H GT1/Nvidia T600 Mobile
32 GB RAM

Arch Linux/Windows 11
AMD Ryzen 2600
Nvidia GTX 1070
16 GB RAM

This PR uses non-final version of the color edit implementation from my other PR. I intend to fix it when the status of the other PR is clarified.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering

@Krzysztof-Dmitruk-Mobica Krzysztof-Dmitruk-Mobica changed the title WIP Add the dynamic blending sample for VK_EXT_extended_dynamic_state3 WIP Add a dynamic blending sample for VK_EXT_extended_dynamic_state3 Jul 10, 2023
@Krzysztof-Dmitruk-Mobica Krzysztof-Dmitruk-Mobica force-pushed the dynamic_blending branch 4 times, most recently from 87c4677 to 95307f7 Compare July 15, 2023 18:50
@Krzysztof-Dmitruk-Mobica Krzysztof-Dmitruk-Mobica changed the title WIP Add a dynamic blending sample for VK_EXT_extended_dynamic_state3 Add a dynamic blending sample for VK_EXT_extended_dynamic_state3 Jul 15, 2023
@asuessenbach
Copy link
Contributor

Nice!
Just a couple of (mostly) minor issues.

@gary-sweet
Copy link
Contributor

I can't test this one unfortunately since we don't support dynamic ColorBlendAdvanced.
Just wondering if the sample could actually not require that, but just use it if available?

SaschaWillems
SaschaWillems previously approved these changes Jul 31, 2023
Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this sample 👍

Runs fine for me. I only found a very small typo in the readme, so I'll give this an approval :)

samples/extensions/dynamic_blending/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@asuessenbach asuessenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized, I didn't submit my review, yet!
Done now.

framework/gui.cpp Outdated Show resolved Hide resolved
samples/extensions/dynamic_blending/README.md Outdated Show resolved Hide resolved
samples/extensions/dynamic_blending/README.md Outdated Show resolved Hide resolved
samples/extensions/dynamic_blending/README.md Outdated Show resolved Hide resolved
samples/extensions/dynamic_blending/README.md Outdated Show resolved Hide resolved
samples/extensions/dynamic_blending/README.md Outdated Show resolved Hide resolved
samples/extensions/dynamic_blending/dynamic_blending.cpp Outdated Show resolved Hide resolved
samples/extensions/dynamic_blending/dynamic_blending.cpp Outdated Show resolved Hide resolved
framework/gui.h Show resolved Hide resolved
Add blend equadion extension support
Add blend advanced extension support
asuessenbach
asuessenbach previously approved these changes Sep 5, 2023
@SaschaWillems SaschaWillems self-requested a review September 25, 2023 15:17
@marty-johnson59 marty-johnson59 merged commit 5310b6f into KhronosGroup:main Sep 25, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants