Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change *Builder::with_implicit_sharing_mode to select concurrent sharing mode when the queueFamilyIndexCount is greater than 1, not different from zero. #1218

Merged

Conversation

asuessenbach
Copy link
Contributor

@asuessenbach asuessenbach commented Nov 5, 2024

Description

This PR resolves a VVL error with the performance sample multi_draw_indirect:

Validation Error: [ VUID-VkBufferCreateInfo-sharingMode-00914 ] | MessageID = 0xa9d5cd94 | vkCreateBuffer(): pCreateInfo->sharingMode VK_SHARING_MODE_CONCURRENT, but queueFamilyIndexCount is 1.
The Vulkan spec states: If sharingMode is VK_SHARING_MODE_CONCURRENT, queueFamilyIndexCount must be greater than 1 (https://vulkan.lunarg.com/doc/view/1.3.296.0/windows/1.3-extensions/vkspec.html#VUID-VkBufferCreateInfo-sharingMode-00914)

Includes some cleanup in buffer.h, hpp_image.h, and image.h.

Build tested on Win10 with VS2022. Run tested on Win10 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@asuessenbach asuessenbach requested a review from a team November 6, 2024 13:03
@asuessenbach asuessenbach added the framework This is relevant to the framework label Nov 6, 2024
@asuessenbach
Copy link
Contributor Author

No idea how to resolve the Antora documentation build failure!

@SaschaWillems
Copy link
Collaborator

SaschaWillems commented Nov 8, 2024

The Antora build failure has been fixed on main and can be safely ignored. It's not caused by our changes.

@SaschaWillems SaschaWillems self-requested a review November 9, 2024 19:46
…ing mode when the queueFamilyIndexCount is greater than 1, not different from zero.
@marty-johnson59 marty-johnson59 merged commit a4efbad into KhronosGroup:main Nov 18, 2024
24 checks passed
@asuessenbach asuessenbach deleted the with_implicit_sharing_mode branch November 26, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework This is relevant to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants