Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline stats in HPPTerrainTessellation #1209

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

yknishidate
Copy link
Contributor

@yknishidate yknishidate commented Oct 26, 2024

Description

Fixed pipeline stats in the hpp_terrain_tessellation sample.

The bug was caused by copying result.value when the query result was NotReady. The original C sample (vkGetQueryPoolResults) also generated NotReady, but since the result value was not written to the output pointer, the same problem as the HPP version did not occur.

The bug can also be fixed by setting the VK_QUERY_RESULT_WAIT_BIT flag, but to match the behavior of the original C sample, I modified it to only read the value if the result was Success.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Copy link
Contributor

@asuessenbach asuessenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Thanks for this fix.

@SaschaWillems SaschaWillems self-requested a review October 28, 2024 20:11
Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Explains (and fixes) the issue I had with the HPP variant of this sample :)

@marty-johnson59 marty-johnson59 merged commit 3f2546d into KhronosGroup:main Nov 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPP terrain tessellation sample reports wrong statistics
5 participants