Fix pipeline stats in HPPTerrainTessellation #1209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed pipeline stats in the hpp_terrain_tessellation sample.
The bug was caused by copying
result.value
when the query result was NotReady. The original C sample (vkGetQueryPoolResults
) also generated NotReady, but since the result value was not written to the output pointer, the same problem as the HPP version did not occur.The bug can also be fixed by setting the
VK_QUERY_RESULT_WAIT_BIT
flag, but to match the behavior of the original C sample, I modified it to only read the value if the result was Success.General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including: