Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a validation error in the logic operations dynamic state sample #1208

Merged

Conversation

yknishidate
Copy link
Contributor

Description

The following validation error was output in the logic operations dynamic state sample.

vkCmdDrawIndexed(): the topology set is VK_PRIMITIVE_TOPOLOGY_TRIANGLE_LIST, the primitiveTopologyListRestart feature was not enabled, but vkCmdSetPrimitiveRestartEnable last set primitiveRestartEnable to VK_TRUE.

VK_EXT_primitive_topology_list_restart and VkPhysicalDevicePrimitiveTopologyListRestartFeaturesEXT have been enabled.

  • This PR has only been tested on Windows.
  • There are no related issues.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

@SaschaWillems SaschaWillems self-requested a review October 28, 2024 20:13
@marty-johnson59 marty-johnson59 merged commit 75700d3 into KhronosGroup:main Nov 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants