Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix archive-sdk when running on wsl #517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danwillm
Copy link

When trying to run maintainer-scripts/archive-sdk.sh on wsl, it failed to build the headers with No generator options for unknown target: openxr.h. This seemed to be because there was an extra character at the end of the filename, so failed to find the key in genOpts.

This removes the whitespace at the end of the strings before passing it to genxr.py to get it working.

@rpavlik
Copy link
Contributor

rpavlik commented Jan 6, 2025

Well that is an interesting failure mode - I assume you're running it on a clone on Windows so it used CRLF EOLs, but bash in WSL isn't stripping those of course.

Can we just do the trim in the python script instead? One less process invocation per file, etc.

@rpavlik rpavlik self-requested a review January 6, 2025 16:47
@danwillm
Copy link
Author

danwillm commented Jan 6, 2025

Thanks - I did originally test just having the strip in python, but there's also places in the script that need the stripped name too, i.e. in add_to_tar when adding the files. Otherwise, it fails with tar: include/openxr/openxr.h\r: Cannot stat: No such file or directory.

Happy to make changes if you have any ideas, let me know.

@rpavlik
Copy link
Contributor

rpavlik commented Jan 6, 2025

Ah, OK, that makes sense then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants