Convert backgroundImage dimensions to numbers during parsing #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (74aa161) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1923If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1923 |
|
Size Change: +71 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
benchristel
changed the base branch from
benc/inline-version-in-expression-widget-parser
to
main
An error occurred while trying to automatically change base from
benc/inline-version-in-expression-widget-parser
to
main
November 27, 2024 17:57
benchristel
force-pushed
the
benc/parse-backgroundImage-numbers
branch
from
72ecdd0
to
73648ba
Compare
jeremywiebe
approved these changes
Nov 28, 2024
Comment on lines
+15
to
+17
| const numericToNumber = pipeParsers(union(number).or(string).parser).then( | ||
| stringToNumber, | ||
| ).parser; |
There was a problem hiding this comment.
I don't understand why we need to union number or string and then pass that result through stringToNumber. Doesn't stringToNumber handle parsing a string or number within itself already?
| @@ -0,0 +1,17 @@ | |||
| import type {PartialParser} from "../parser-types"; | |||
|
|
|||
| export const stringToNumber: PartialParser<string | number, number> = ( | |||
There was a problem hiding this comment.
Sadly, there is more than one place where Perseus data contains both actual numbers and stringified numbers.
No action needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: LEMS-2582
Test plan:
yarn test