update: change address type to enum

libs/ur-registry/src/cardano/cardano_sign_cip8_data_request.rs

@@ -21,6 +21,33 @@ const HASH_PAYLOAD: u8 = 7;
 
 const ADDRESS_BENCH32: u8 = 8;
 const ADDRESS_TYPE: u8 = 9;
+// https://github.com/LedgerHQ/app-cardano/blob/develop/src/signMsg.c#L175-L189
+
+#[derive(Debug, Clone, Copy, Default)]
+pub enum Cip8AddressType {
+    #[default]
+    Address,
+    KeyHash,
+}
+
+impl Cip8AddressType {
+    pub fn as_str(&self) -> &'static str {
+        match self {
+            Cip8AddressType::Address => "ADDRESS",
+            Cip8AddressType::KeyHash => "KEY_HASH",
+        }
+    }
+}
+
+impl From<&str> for Cip8AddressType {
+    fn from(s: &str) -> Self {
+        match s {
+            "ADDRESS" => Cip8AddressType::Address,
+            "KEY_HASH" => Cip8AddressType::KeyHash,
+            _ => panic!("Invalid AddressType string"),
+        }
+    }
+}
 
 impl_template_struct!(CardanoSignCip8DataRequest {
     request_id: Option<Bytes>,
@@ -30,7 +57,7 @@ impl_template_struct!(CardanoSignCip8DataRequest {
     xpub: Bytes,
     hash_payload: bool,
     address_bench32: Option<String>,
-    address_type:String
+    address_type: Cip8AddressType
 });
 
 impl MapSize for CardanoSignCip8DataRequest {
@@ -79,7 +106,8 @@ impl<C> minicbor::Encode<C> for CardanoSignCip8DataRequest {
             e.int(Int::from(ADDRESS_BENCH32))?.str(address_bench32)?;
         }
 
-        e.int(Int::from(ADDRESS_TYPE))?.str(&self.address_type)?;
+        e.int(Int::from(ADDRESS_TYPE))?
+            .str(&self.address_type.as_str())?;
 
         CryptoKeyPath::encode(&self.derivation_path, e, _ctx)?;
 
@@ -122,7 +150,7 @@ impl<'b, C> minicbor::Decode<'b, C> for CardanoSignCip8DataRequest {
                     obj.address_bench32 = Some(d.str()?.to_string());
                 }
                 ADDRESS_TYPE => {
-                    obj.address_type = d.str()?.to_string();
+                    obj.address_type = Cip8AddressType::from(d.str()?);
                 }
                 _ => {}
             }