Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/65 close memory mapped buffer #66

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

TomHKeysight
Copy link
Collaborator

This PR fixes issue #65.

Unfortunately, the current solution requires a garbage collect to have been performed before the issue is resolved.
Other fixes required either a Java 8 Cleaner.clean() call not accessible from Java 21, or a Java 20 Arena.close(), which is not been finalized in Java 21.
Copy link
Collaborator

@matthijsgeers-keysight matthijsgeers-keysight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not bump to release version on the develop branch

@TomHKeysight TomHKeysight force-pushed the bugfix/65-close-memory-mapped-buffer branch from 85ace61 to 3162738 Compare November 29, 2024 15:30
@matthijsgeers-keysight matthijsgeers-keysight merged commit 7dafd19 into develop Nov 29, 2024
1 check passed
@matthijsgeers-keysight matthijsgeers-keysight deleted the bugfix/65-close-memory-mapped-buffer branch November 29, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants