-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexibility refactor #9
base: main
Are you sure you want to change the base?
Conversation
It would be nice to show the intended use, and give a couple examples what to use bindings for... |
Added a few examples at the top of the bind.proto file |
Removed the linktype as it adds overhead and opens the link message to interpretation. The bandwidth message in the link is the most important piece and is required. A description field has been added instead so that additional details describing the link can be provided. To categorize the link the bind.proto should be used. @harsh-sikhwal |
Revised the bind.proto to allow a user to specify multiple bind targets to one user defined data message, prior to this change you had to repeat the user defined message if it was to be applied to multiple disparate instances. |
In general, I approve of the change. I think this technically covers every way that a binding might be attached to a subset of the entire infrastructure, with a potential drawback being |
re: target lists can get large - this buys time to evaluate alternate scaling techniques for indexing and avoid api churn |
The current version of infra.proto is not flexible enough to accommodate better device reuse, more complex topologies and external third party data. At this time there is also no specific rpc for model validation. In addition there is code that builds concrete infrastructure objects that is application specific and should not be part of this repository.
This PR will address the following: