feat: Added wallet cache #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable the wallet cache, set
KC_WALLET_CACHE=truein your .env. This applies to the CLI and to keymaster-api.Benchmarks to create 20 credentials using
./kc perf-test 20With unencrypted wallets, the cache has little effect (as expected). With encrypted wallets the cache make credential issuance substantially faster (at the expense of keeping the private keys in memory so there is a security trade off to consider here).
If the wallet cache is used, and the deployment scenario has multiple services using the same wallet, then they should be configured to have keymaster-api be the interface to the wallet, and the rest should be configured to use keymaster-api. To that end, the satoshi-mediator was refactored to use keymaster SDK so that there is no contention for the wallet.
Likewise, if you use the CLI you should set
KC_KEYMASTER_URL=http://localhost:4226in your .env so it uses the REST API.