Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaxscrip deployment guide 1 #395

Merged
merged 31 commits into from
Dec 20, 2024
Merged

Flaxscrip deployment guide 1 #395

merged 31 commits into from
Dec 20, 2024

Conversation

Flaxscrip
Copy link
Contributor

Proper request: Thank you for your review @alexfornuto.

@Flaxscrip Flaxscrip added the documentation Improvements or additions to documentation label Oct 30, 2024
@Flaxscrip Flaxscrip requested a review from alexfornuto October 30, 2024 14:34
@Flaxscrip Flaxscrip self-assigned this Oct 30, 2024
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
doc/deployment_guide.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flaxscrip I've edited what I'm confident in changing, and completed my remarks on what else should be changed.

In general, I think we should deploy this page for now as is (once edits are complete). Once done, we should revisit this content with an eye towards turning it into a muli-page section of the docs site. There's a lot of useful information here, and it's not all specific to the deployment process. Breaking it into pages will make this information easier to find when required for other uses.

@macterra macterra force-pushed the Flaxscrip-deployment-guide-1 branch from 1e53a97 to f906964 Compare December 9, 2024 21:19
Copy link
Collaborator

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the presumption that outstanding notes will be added to an issue to track and update at a later date.

@Flaxscrip
Copy link
Contributor Author

This document will continue to continuously change as we define new deployment best practices. As such, I'd like to publish what we have and continue to improved based on the current and upcoming feedback from 3rd party partners.

Copy link
Collaborator

@macterra macterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment with a link to a single issue that references this PR for deferred work

@Flaxscrip
Copy link
Contributor Author

Flaxscrip commented Dec 20, 2024

We will review and resolve the remaining comments as part of work for #504 in 2025

@macterra macterra merged commit 8f9ec02 into main Dec 20, 2024
9 checks passed
@macterra macterra deleted the Flaxscrip-deployment-guide-1 branch December 20, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants