-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds retrieval logic #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Everything, checks out, don't mind the failed tests, I'll run the tests with my environment variables.
Is there a dependency that needs to be added to use
from operator import itemgetter
and from langchain_core.prompts import PromptTemplate
imports, if there is kindly add them to the PR in both requirements.txt
and setup.cfg
.
And could you remove one import of from langchain_pinecone import PineconeVectorStore
module, it's imported twice in both files.
yeah only for langchain core though , I'm on my way home. will fix when I get home |
Fixed it. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Merged🥳 |
🥳🥳🥳🥳 |
rerankers next. Still reading about them. |
Btw kindly test the method. I just noticed a bug retriever = vector_store.as_retriver(search_kwargs = {"k": top_k}) fix the above in both openai and google to : retriever = vector_store.as_retriever(search_kwargs = {"k": top_k}) missed the e in the retriever |
Nice. |
great |
adds retrieval logic using LCEL
If any changes is required please let me know.
Thank you