Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Invalid event handling, for bulk conversion #39

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ro5490
Copy link

@ro5490 ro5490 commented Nov 25, 2024

Shows errors when they happen and logs them to the conversion txt
Same for index range issues with songs not existing or something
DOES NOT FIX THE ERRORS, Just skips the midi for now.

Tl;Dr - You can now bulk-convert a few hundred thousand midi's with almost no issue

image
image

@ro5490
Copy link
Author

ro5490 commented Nov 25, 2024

Fixes #9 #15
(Via skipping the error files, you should probably just validate your midi files first tbh)

@ro5490
Copy link
Author

ro5490 commented Nov 25, 2024

Also working an update that sorts out 100% after shift, and 0-shift 100% files into seperate folders

@ro5490 ro5490 marked this pull request as ready for review November 25, 2024 20:06
@ro5490
Copy link
Author

ro5490 commented Nov 25, 2024

Take a look at #40 if you'd prefer multithreading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant