Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to run in a docker container #178

Closed
wants to merge 3 commits into from

Conversation

sirinsidiator
Copy link
Contributor

@sirinsidiator sirinsidiator commented Feb 16, 2024

This adds a Dockerfile to build the application and install ffmpeg so it can be run in a container. I have also updated the readme and added an example configuration for docker compose.

Inside the container the application is run as a non-priviledged user, so I have added some cli arguments to make it possible to work around any permission problems that may arise due to that:
--file-permissions (or -fp) and --directory-permissions (or -dp) to specify which mode is used to create files and directories.

In addition I also added another option --temp-directory (or -td) to specify a directory for temporary files which solves #175 for me.

Disclaimer: This is the first time I did anything with go, so please excuse if I made any obvious mistakes in the code. It compiles and runs fine though, so hopefully everything should be ok.

@Kethsar
Copy link
Owner

Kethsar commented Feb 16, 2024

I'm not accepting commits to add Docker support directly into this repo. See #100 (comment)

If you make it so only changes regarding the new options are added, I'll be willing merge after testing it if it works.

@sirinsidiator
Copy link
Contributor Author

Fair enough. I've created a new pull request for them. See #179 .

@sirinsidiator
Copy link
Contributor Author

You could still add a short note to the readme regarding your stance though. I did look through the issues, but missed the pull request since github didn't include them in the search and I didn't actually expect there to be one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants