-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volodymyr.savchenko #85
base: master
Are you sure you want to change the base?
Conversation
Add: game "Rock, Paper, Scissors" and Makefile for the game build Signed-off-by: volnsav <[email protected]>
Add: home task 03-bash/make_soup Fix: 03-bash. Format scripts and replace [[ with [ in 02-bash, add target "all", xchange main.o and hello in target "hello", remove unnecessary hyphen before rm, remove main and a.out from target "clean" Signed-off-by: volnsav <[email protected]>
Add: source and make files for create simple kernel module, dmesg logfile with trace log while load and unload kernel module Signed-off-by: volnsav <[email protected]>
Add hometask 4 |
Signed-off-by: Andriy Khulap <[email protected]>
Add: simple kernel module wich works with procfs and convert char in lower case to upper case, dmesg log file. Signed-off-by: volnsav <[email protected]>
Add: store and show convertor statistics in path /proc/myprocfs/stat, change convertor path to /proc/myprocfs/convertor. Signed-off-by: volnsav <[email protected]>
Add: simple lowercase converter based on sysfs classes, dmesg and shell log. Signed-off-by: volnsav <[email protected]>
Add: kernel module source file and log file Signed-off-by: volnsav <[email protected]>
Add homework #6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minor changes are needed IMO
06-TimeManagement/dmesg_timer.log
Outdated
[16121.523508] my_time: call my_timer_callback, delay: 5000 [ms] | ||
[16126.639240] my_time: call my_timer_callback, delay: 5000 [ms] | ||
[16131.754892] my_time: call my_timer_callback, delay: 5000 [ms] | ||
[16134.670267] my_time: call my_store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call my_store
I'm wondering how this can help in debugging?
It reflects just a fact of callback call, but what parameters were pased into?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value of delay (5000) is passed into.
06-TimeManagement/my_time.c
Outdated
pr_info("my_time: call %s, can't read delay value!\n", __func__); | ||
} | ||
|
||
if (delta_in_ms < MIN_DELAY_IN_MS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (delta_in_ms < MIN_DELAY_IN_MS) {
In this case the timer will be restarted with default value, correct?
So the previous delay period successfully set before would be dropped.
06-TimeManagement/my_time.c
Outdated
static void my_timer_callback(unsigned long data) | ||
{ | ||
pr_info("my_time: call %s, delay: %lu [ms]\n", __func__, delta_in_ms); | ||
mod_my_timer(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is no way to stop this timer.
Fix: set timer off if 0 obtained, improve debug messages Signed-off-by: volnsav <[email protected]>
Fix lesson 06 homework |
Add: kernel module source file and log (dmesg and system) Signed-off-by: volnsav <[email protected]>
Add homework 7 task 01 - slab allocator |
@volnsav, |
clean: | ||
rm -rf $(KITCHEN) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing empty lines in the end of file.
# echo ">>>>>>>>>> dir >>>>>>>>>>> $1" | ||
if ! [ -d $1 ]; then | ||
mkdir -p $1 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty line is absent in the end of file.
INSTALL_DIR="/usr/local/bin" | ||
INSTALL_FILE="task1.sh" | ||
|
||
if [ -z "$1" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be better to check the existing file using [ -f ... ]
Fix errors and merge commits