Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volodymyr.savchenko #85

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Volodymyr.savchenko #85

wants to merge 12 commits into from

Conversation

volnsav
Copy link

@volnsav volnsav commented Nov 12, 2018

Fix errors and merge commits

Add: game "Rock, Paper, Scissors" and Makefile for the game build

Signed-off-by: volnsav <[email protected]>
Add: home task 03-bash/make_soup

Fix: 03-bash. Format scripts and replace [[ with [ in 02-bash, add
target "all", xchange main.o and hello in target "hello", remove
unnecessary hyphen before rm, remove main and a.out from target
"clean"

Signed-off-by: volnsav <[email protected]>
@volnsav volnsav requested a review from yekovalyov November 12, 2018 21:53
Add: source and make files for create simple kernel module, dmesg
logfile with trace log while load and unload kernel module

Signed-off-by: volnsav <[email protected]>
@volnsav volnsav requested a review from an1kh November 12, 2018 22:15
@volnsav
Copy link
Author

volnsav commented Nov 12, 2018

Add hometask 4

an1kh and others added 3 commits November 13, 2018 23:32
Add: simple kernel module wich works with procfs and convert char
in lower case to upper case, dmesg log file.

Signed-off-by: volnsav <[email protected]>
@volnsav volnsav added the ready label Nov 14, 2018
volnsav and others added 4 commits November 14, 2018 09:40
Add: store and show convertor statistics in  path /proc/myprocfs/stat, change convertor path to
/proc/myprocfs/convertor.

Signed-off-by: volnsav <[email protected]>
Add: simple lowercase converter based on sysfs classes, dmesg and
shell log.

Signed-off-by: volnsav <[email protected]>
Add: kernel module source file and log file

Signed-off-by: volnsav <[email protected]>
@volnsav
Copy link
Author

volnsav commented Nov 18, 2018

Add homework #6

Copy link
Contributor

@DevyatovAndrey DevyatovAndrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minor changes are needed IMO

[16121.523508] my_time: call my_timer_callback, delay: 5000 [ms]
[16126.639240] my_time: call my_timer_callback, delay: 5000 [ms]
[16131.754892] my_time: call my_timer_callback, delay: 5000 [ms]
[16134.670267] my_time: call my_store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call my_store

I'm wondering how this can help in debugging?
It reflects just a fact of callback call, but what parameters were pased into?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value of delay (5000) is passed into.

pr_info("my_time: call %s, can't read delay value!\n", __func__);
}

if (delta_in_ms < MIN_DELAY_IN_MS) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (delta_in_ms < MIN_DELAY_IN_MS) {

In this case the timer will be restarted with default value, correct?
So the previous delay period successfully set before would be dropped.

static void my_timer_callback(unsigned long data)
{
pr_info("my_time: call %s, delay: %lu [ms]\n", __func__, delta_in_ms);
mod_my_timer();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is no way to stop this timer.

@DevyatovAndrey DevyatovAndrey added changes requested The PR review revealed issues which should be fixed (set by reviewer). and removed ready labels Nov 19, 2018
Fix: set timer off if 0 obtained, improve debug messages

Signed-off-by: volnsav <[email protected]>
@volnsav volnsav added ready and removed changes requested The PR review revealed issues which should be fixed (set by reviewer). labels Nov 19, 2018
@volnsav
Copy link
Author

volnsav commented Nov 19, 2018

Fix lesson 06 homework

Add: kernel module source file and log (dmesg and system)

Signed-off-by: volnsav <[email protected]>
@volnsav
Copy link
Author

volnsav commented Nov 21, 2018

Add homework 7 task 01 - slab allocator

@AleksandrBulyshchenko
Copy link
Contributor

@volnsav,
Could you please split this PR into several (per lesson)

clean:
rm -rf $(KITCHEN)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing empty lines in the end of file.

# echo ">>>>>>>>>> dir >>>>>>>>>>> $1"
if ! [ -d $1 ]; then
mkdir -p $1
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line is absent in the end of file.

INSTALL_DIR="/usr/local/bin"
INSTALL_FILE="task1.sh"

if [ -z "$1" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be better to check the existing file using [ -f ... ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants