ssd1306: simple driver with user application #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added base implemantaion of lcd-driver. Added slightly improved user-aplication: avoided redundant redrawing. Added sample of uEnv.txt that allows to use i2c1 for ssd1306. Rude disabling of hdmi in device tree: for some reason was created fb0 and no interruption were received for fb1 (ssd1306).
DevyatovAndrey
requested changes
Jan 10, 2018
| struct ssd1306_data *lcd = | ||
| container_of(work, struct ssd1306_data, display_update_ws); | ||
| ssd1307fb_update_display(lcd); | ||
| //ssd1306_UpdateScreen(lcd); |
There was a problem hiding this comment.
remove unnesessary comments/lines
|
|
||
| if (copy_from_user(dst, buf, count)) { | ||
| pr_err("%s copy_from_user", __FUNCTION__); | ||
| //return -EFAULT; |
There was a problem hiding this comment.
fb_sys_write method could be called there
| return -ENOMEM; | ||
| } | ||
|
|
||
| vmem = lcd_vmem;//&ssd1306_Buffer[0]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added base implemantaion of lcd-driver.
Added slightly improved user-aplication: avoided redundant redrawing.
Added sample of uEnv.txt that allows to use i2c1 for ssd1306.
Rude disabling of hdmi in device tree: for some reason was created
fb0 and no interruption were received for fb1 (ssd1306) and cape_disable doesn't work for that purpose.