Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpu6050 read data by time with kthread wariant #46

Open
wants to merge 1 commit into
base: Dmytro.Kirtoka
Choose a base branch
from

Conversation

dmytrokirtoka
Copy link

added ring buffer with 10 elm
added module parameter rate, default is 1000 msec
added kthread for periodic read data from device by msleep delay.

added ring buffer with 10 elm
added module parameter rate, default is 1000 msec
added kthread for periodic read data from device by delay
Copy link
Contributor

@an1kh an1kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have no objections to idea and implementation. But the code has some formatting issues like spacing. Please fix them and merge.
I'll go ahead and ack.

@an1kh an1kh mentioned this pull request Dec 12, 2017
Copy link
Collaborator

@AleksandrBulyshchenko AleksandrBulyshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kthread usage seems OK,

But commit message requires rewriting and checkpatch issues should be fixed.

Anyway AFAIU, this PR isn't going to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants