A solution for the sixth hw (irq) #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver consists of the source file, dts overlay and registers description. When the device is detected, it's initialized with a default configuration, that can be seen in the source file. It also has a single sysfs entry, which reads from the device its id, and prints what type of device is attached, if it's supported. Signed-off-by: Andrii Revva <[email protected]>
Signed-off-by: Andrii Revva <[email protected]>
Signed-off-by: Andrii Revva <[email protected]>
Signed-off-by: Andrii Revva <[email protected]>
It seems like a redundant thing, because to precicely calculate lux values from adc0 and adc1 it's beneficial to have floating point arithmetic. So it would be nice to pass this obligation to user space. The method to approximately calculate lux values comes from the datasheet and it is _absolutely_ arcane and obscure. Signed-off-by: Andrii Revva <[email protected]>
Three additional fields were declared in the tsl2580 device struct to store previously read values. Signed-off-by: Andrii Revva <[email protected]>
Signed-off-by: Andrii Revva <[email protected]>
Signed-off-by: Andrii Revva <[email protected]>
Signed-off-by: Andrii Revva <[email protected]>
Signed-off-by: Andrii Revva <[email protected]>
A mutex is used to make protection. The mutex use is coarse, since this particular protection isn't really neccessary, because only one thread is writing data to structure, and other threads wait for completeion. Signed-off-by: Andrii Revva <[email protected]>
By default, the device can be accessed every second, although it can be changed with 'rt' attribute in sysfs. Signed-off-by: Andrii Revva <[email protected]>
Signed-off-by: Andrii Revva <[email protected]>
Signed-off-by: Andrii Revva <[email protected]>
Interrupt handles is called only once, because the interrupt must be reset for the device, and it must be done in non-irq context. It must be deffered into either tasklet or workqueue. Signed-off-by: Andrii Revva <[email protected]>
Workqueue is used to deffer interrupt work. It uses the same thread to access device as sysfs intefaces. Signed-off-by: Andrii Revva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for the sixth homework.
The GPIO pin is hard coded, and is not instantiated in dt. The driver uses deprecated gpio interface (linux/gpio.h).
Other information can be found in commit messages.