Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Historical task #184

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

WIP: Historical task #184

wants to merge 9 commits into from

Conversation

x-tabdeveloping
Copy link
Collaborator

No description provided.

KennethEnevoldsen
KennethEnevoldsen requested changes Sep 1, 2024
View reviewed changes
Copy link
Owner

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should move to the task outside of the main tasks (that or run all models on it).

src/seb/registered_models/sentence_transformer_models.py Show resolved Hide resolved
@KennethEnevoldsen
Copy link
Owner

@x-tabdeveloping seems like tests don't pass (you need to remove an import), but once that is resolved feel free to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KennethEnevoldsen KennethEnevoldsen KennethEnevoldsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x-tabdeveloping @KennethEnevoldsen