Use plack.request environment instead of private Requset methods

Also set the minimum Plack version to the one which introduced them
Kelp-framework · Jun 20, 2024 · 195b7e2 · 195b7e2
1 parent bb113a8
commit 195b7e2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/cpanfile b/cpanfile
@@ -1,4 +1,4 @@
-requires 'Plack' => '0';
+requires 'Plack' => '1.0041';
 requires 'Log::Dispatch' => '0';
 requires 'JSON::MaybeXS' => '0';
 requires 'Path::Tiny' => '0';

diff --git a/lib/Kelp/Request.pm b/lib/Kelp/Request.pm
@@ -20,21 +20,26 @@ attr route_name => sub { undef };
 
 attr query_parameters => sub {
     my $self = shift;
-    my $raw = $self->_charset_decode_array($self->_query_parameters);
+
+    $self->SUPER::query_parameters;
+    my $raw = $self->_charset_decode_array($self->env->{'plack.request.query_parameters'});
     return Hash::MultiValue->new(@{$raw});
 };
 
 attr body_parameters => sub {
     my $self = shift;
-    my $raw = $self->_charset_decode_array($self->_body_parameters);
+
+    $self->SUPER::body_parameters;
+    my $raw = $self->_charset_decode_array($self->env->{'plack.request.body_parameters'});
     return Hash::MultiValue->new(@{$raw});
 };
 
 attr parameters => sub {
     my $self = shift;
 
-    my $raw_query = $self->_charset_decode_array($self->_query_parameters);
-    my $raw_body = $self->_charset_decode_array($self->_body_parameters);
+    $self->SUPER::parameters;
+    my $raw_query = $self->_charset_decode_array($self->env->{'plack.request.query_parameters'});
+    my $raw_body = $self->_charset_decode_array($self->env->{'plack.request.body_parameters'});
     return Hash::MultiValue->new(@{$raw_query}, @{$raw_body});
 };