fixed: field value can be of type string

Keleo · Mar 9, 2023 · 6c9ba90 · 6c9ba90
1 parent 155e086
commit 6c9ba90
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Version 2.0.1
+
+Compatibility: requires minimum Kimai 2.0
+
+- Fixed: field value can be of type string  
+
 ## Version 2.0
 
 Compatibility: requires minimum Kimai 2.0

diff --git a/Timesheet/Calculator/DeductionTimeCalculator.php b/Timesheet/Calculator/DeductionTimeCalculator.php
@@ -24,13 +24,11 @@ public function calculate(Timesheet $record, array $changeset): void
 
         $meta = $record->getActivity()->getMetaField(DeductionTimeBundle::META_FIELD_DEDUCTION)?->getValue();
 
-        if (!\is_bool($meta) || $meta === false) {
-            return;
-        }
-
-        $duration = $record->getDuration(false);
-        if ($duration > 0) {
-            $record->setDuration($duration * -1);
+        if ($meta === true || $meta === '1') {
+            $duration = $record->getDuration(false);
+            if ($duration > 0) {
+                $record->setDuration($duration * -1);
+            }
         }
     }
 

diff --git a/composer.json b/composer.json
@@ -3,7 +3,7 @@
     "description": "Configure certain activities as deduction time, resulting in negative durations for timesheets.",
     "homepage": "https://www.kimai.org/store/keleo-deduction-time-bundle.html",
     "type": "kimai-plugin",
-    "version": "2.0",
+    "version": "2.0.1",
     "keywords": [
         "kimai",
         "kimai-plugin"