Add Secure OS Storage Option #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndlessTrax
force-pushed
the
add-secure-config-storage
branch
from
bb1d939 to
a035b6e
Compare
EndlessTrax
force-pushed
the
add-secure-config-storage
branch
from
c54a667 to
a25d8a7
Compare
maksimu
previously approved these changes
Jul 26, 2024
borrow-checker
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced an option for the user to use a secure storage option for configuration file to avoid KSM configuration files being store in a plaintext file.
The storage interface makes use of the
windows-credential-manager-utilityor thelinux-keyring-utilityto intact with the operating systems native secrets platform (i.e. Windows Credential Manager or Linux Keyring).In order to use the
SecureOSStoragethe user is expected to set aKSM_CONFIG_SECUREenvironment variable toTrue.Optionally, the user may set
KSM_CONFIG_EXE_PATHto the path of the utility executable (listed above). By default,SecureOSStoragewill check the usersPATHfor the utility. By setting the environment variable, users have the option to run the executable directly without it being part ofPATH.