Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSM-490 - .NET SDK: Switch some internal classes to public - for use in plugins #563

Merged
merged 3 commits into from
Jun 7, 2024
Merged

KSM-490 - .NET SDK: Switch some internal classes to public - for use in plugins #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b89859
KSM-490 Switch some internal classes to public - for use in plugins
idimov-keeper Jan 31, 2024
ccf3839
Updated readme
idimov-keeper Jun 7, 2024
001314a
Merge branch 'release/sdk/dotnet/core/v16.6.6' into KSM-490-ksm-net-s…
idimov-keeper Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/dotNet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

## 16.6.6

* KSM-490 - Switch some internal classes to public - for use in plugins
* KSM-515 - Update to Bouncy Castle 2.4.0

## 16.6.5
Expand Down
4 changes: 2 additions & 2 deletions sdk/dotNet/SecretsManager/Notation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ KeeperRecordField FindField(string fieldName)
}

// data class to represent parsed notation section
internal class NotationSection
public class NotationSection
{
public string Section = null; // section name - ex. prefix
public bool IsPresent = false; // presence flag
Expand Down Expand Up @@ -281,7 +281,7 @@ private static NotationSection ParseSection(string notation, string section, int
return result;
}

internal static List<NotationSection> ParseNotation(string notation, bool legacyMode = false)
public static List<NotationSection> ParseNotation(string notation, bool legacyMode = false)
{
if (string.IsNullOrEmpty(notation))
throw new Exception("Keeper notation is missing or invalid.");
Expand Down
5 changes: 1 addition & 4 deletions sdk/dotNet/SecretsManager/SecretsManagerClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,11 @@
using System.Linq;
using System.Net;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Text;
using System.Text.Json;
using System.Text.RegularExpressions;
using System.Threading.Tasks;

[assembly: InternalsVisibleTo("SecretsManager.Test.Core")]

namespace SecretsManager
{
using GetRandomBytesFunction = Func<int, byte[]>;
Expand Down Expand Up @@ -1412,7 +1409,7 @@ private static TransmissionKey GenerateTransmissionKey(IKeyValueStorage storage)

[SuppressMessage("ReSharper", "MemberCanBePrivate.Global")]
[SuppressMessage("ReSharper", "UnusedAutoPropertyAccessor.Global")]
internal static GetRandomBytesFunction TransmissionKeyStub { get; set; }
public static GetRandomBytesFunction TransmissionKeyStub { get; set; }

private static EncryptedPayload EncryptAndSignPayload<T>(IKeyValueStorage storage,
TransmissionKey transmissionKey, T payload)
Expand Down