KSM-463 - Python SDK - fix for record's data JSON where "fields": null #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test for clients that do not store "fields":[] or set it to null
maksimu
changed the title
maksimu
previously approved these changes
Sep 14, 2023
maksimu
changed the base branch from
master
to
release/sdk/python/core/v16.6.2
maksimu
approved these changes
Sep 14, 2023
maksimu
merged commit 5dc2d76
into
release/sdk/python/core/v16.6.2
25 of 29 checks passed
maksimu
added a commit
that referenced
this pull request
Sep 15, 2023
…per (#527) * Update Python SDK to version 16.6.2 and updates change log * KSM-463 - Python SDK - fix for record's data JSON where "fields": null (#525) * KSM-458 Remove core dep on helper module Refactor add_custom_field not to use the helper module. The method will accept an instance of FieldType, however it is not tied to the keeper_secrets_manager_helper.v3.field_type.FieldType module. Allow the ability to set the type, label, and value not using the FieldType instance. The method will still take the param `field`, however it will also take `field_type`, `label`, and `value`. This allows adding a custom field without have to use the helper module. Removed references `keeper-secrets-manager-helper` from setup.py and requirements.txt. This should break the circular reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added test for clients that do not store "fields":[] or set it to null