Add suppot for CSV input #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the input format InputFormat.CSV in parse_lines. In parse_line call the function parse_line_csv if the input format is InputFormat.CSV. The parse_line_csv function extracts the instruction from the line and generates an Instruction instance. Creat an abstract base class TargetInfo for the X86 and ARM target infos. Make the class InputFormat inherit from Enum. Move the classes to the top of the file. Add some comments to document the code.
|
Nice to see some improvements, also in the readme. Thanks! At quick glance the PR looks very solid, but I'll give this a thorough review after I'm not so busy with work. Some tests for CSV would be nice to have though. Also, where this CSV input is coming from? |
Kazhuu
requested changes
Dec 6, 2022
|
|
||
| def parse_function_header(line): | ||
| """ | ||
| Return function name of memory range from the given string line. |
There was a problem hiding this comment.
This comment does not match to what the function is actually returning anymore. This was already here before this PR, so I can also update these after this is merged.
| elements: list[str] = line.split(';') | ||
| addr: Address = Address(int(elements[0])) | ||
| operands: str = elements[3] | ||
| target: Address | None = None |
There was a problem hiding this comment.
More type annotations for this Python project would also be welcome in the future. Good start 👍
| @@ -501,19 +579,26 @@ def parse_lines(lines, skip_calls, target_name): # noqa pylint: disable=unused- | |||
| continue | |||
|
|
|||
| instruction_or_encoding = parse_line(line, num, current_function_name, current_format, target_info) | |||
| # print(instruction_or_encoding) | |||
There was a problem hiding this comment.
Please don't leave commented out lines in the code. Probably mistake :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for CSV like input and do some minor refactoring, also update the README.