-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tests/e2e-evm): Restructure ABI tests for extensibility & reduce duplication #2031
base: nd-implement-basic-precompile-calling
Are you sure you want to change the base?
refactor(tests/e2e-evm): Restructure ABI tests for extensibility & reduce duplication #2031
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dd9b489 - Browse repository at this point
Copy the full SHA dd9b489View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5737b3b - Browse repository at this point
Copy the full SHA 5737b3bView commit details -
fix: Use separate shouldRun fn signatures for fallback tests
Fallback tests are not run on each function but rather only for the specific fallback. This means whether or not to run the test is determined by only the receive and fallback functions, without any other ABI function.
Configuration menu - View commit details
-
Copy full SHA for b184907 - Browse repository at this point
Copy the full SHA b184907View commit details -
fix: Resolve use of type assertions, enforcing types
Previously used type assertions to bypass certain TypeScript issues with test cases, along with using any & unsafe assignments. This resolves the types to be properly valid and enforced to prevent any potential errors.
Configuration menu - View commit details
-
Copy full SHA for 815415c - Browse repository at this point
Copy the full SHA 815415cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ec0ffe - Browse repository at this point
Copy the full SHA 7ec0ffeView commit details
Commits on Oct 9, 2024
-
refactor: Dynamic generation basic ABI test cases
Changes from including a field in each test case from conditionally running the case, to building the cases dynamically. This allows for logical grouping of test cases and organization with logic instead of using comments. Slightly less explicit for each test case, but with the grouping of test cases, it reduces the mental overhead of figuring out when each test case is run.
Configuration menu - View commit details
-
Copy full SHA for 4df0c17 - Browse repository at this point
Copy the full SHA 4df0c17View commit details -
refactor: Resolve ABI disabled types & errors
Resolves use type casting and unsafe access, validation of revert errors for matches and types
Configuration menu - View commit details
-
Copy full SHA for cd15cde - Browse repository at this point
Copy the full SHA cd15cdeView commit details -
refactor: Only test receive, fallback funcs when available
Previously runs all the time, which is currently okay with the current single testing contract that includes both functions. This conditionally adds these test cases if the respective functions exist so we can test additional contract behavior that may not have these functions and may produce a different error.
Configuration menu - View commit details
-
Copy full SHA for 0f248d2 - Browse repository at this point
Copy the full SHA 0f248d2View commit details
Commits on Oct 10, 2024
-
lint: Ignore solhint issues for mock contracts
Most of these issues are intentional and are okay to ignore. This also sets the solhint ignoreConstructors option to true for the func-visibility rule, as we are using solidity >=0.7.0
Configuration menu - View commit details
-
Copy full SHA for 8a90bbc - Browse repository at this point
Copy the full SHA 8a90bbcView commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1d98340 - Browse repository at this point
Copy the full SHA 1d98340View commit details -
chore: Disable chai assertion error truncation
Long errors are truncated and difficult to determine the issue otherwise
Configuration menu - View commit details
-
Copy full SHA for 70f72d8 - Browse repository at this point
Copy the full SHA 70f72d8View commit details