test(ante): Add test to cover various EIP712Domain fields #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drklee3
force-pushed
the
dl-eip712-domainsep-tests
branch
from
6480f76
to
4582ff2
Compare
drklee3
commented
Sep 12, 2024
| }, | ||
| }, | ||
| { | ||
| name: "passes when domain matches expected fields", |
There was a problem hiding this comment.
The added test cases here, the other changes are mostly just to resolve lint errors
drklee3
requested review from
rhuairahrighairidh,
karzak,
pirtleshell,
nddeluca,
DracoLi,
evgeniy-scherbina,
sesheffield,
boodyvo and
lbayas
as code owners
This was referenced Oct 30, 2024
pirtleshell
approved these changes
Nov 1, 2024
| @@ -240,7 +240,7 @@ replace ( | |||
| // Use ethermint fork that respects min-gas-price with NoBaseFee true and london enabled, and includes eip712 support | |||
| // Tracking kava-labs/etheremint master branch | |||
| // TODO: Tag before release | |||
| github.com/evmos/ethermint => github.com/kava-labs/ethermint v0.21.1-0.20240802224012-586960857184 | |||
| github.com/evmos/ethermint => github.com/kava-labs/ethermint v0.21.1-0.20240919184235-65384e03c3e7 | |||
There was a problem hiding this comment.
does this have some precompile things that v0.21.0-kava-v27.0 does not?
There was a problem hiding this comment.
hmm yes this commit hash version is from master that includes some precompile work -- Will close this PR for #2044 since that one also includes these same ante tests and additional e2e changes, then backport onto master with this ethermint version
| customDomainTypes, | ||
| ) | ||
|
|
||
| // Sign sighHash |
There was a problem hiding this comment.
Suggested change
| // Sign sighHash | |
| // Sign sigHash |
| }, | ||
| }, | ||
| { | ||
| name: "fails when domain.verifyingContract is non-empty string type", |
1 task
|
Superseded by #2045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
verifyingContractandsaltfieldsDepends on Ethermint PR: Kava-Labs/ethermint#75
Also manually tested EIP712 transaction with the expected EIP712Domain fields with MetaMask.
Checklist