Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ledger-cosmos-go to v0.13.1 #534

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Update ledger-cosmos-go to v0.13.1 #534

merged 1 commit into from
Nov 16, 2023

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Nov 11, 2023 •
edited
Loading

Fixes failure to sign txs via cli with cosmos ledger app 2.34.12 and cosmos-ledger-go @ v0.12.2

Example of failure, with blank error message

confirm transaction before signing and broadcasting [y/N]: y
Error: 
Usage:
...

Relevant breaking change: https://github.com/cosmos/ledger-cosmos-go/pull/39/files

@drklee3 drklee3 marked this pull request as ready for review November 13, 2023 20:44
rhuairahrighairidh
rhuairahrighairidh approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@rhuairahrighairidh rhuairahrighairidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thought I haven't dug super deep, or tested with a ledger. However it looks like it only effects cli code.

suggestion: adding more description to the PR could help when we need to reapply these patches to updgrade the cosmos-sdk version.

@drklee3 drklee3 merged commit b8317d8 into kava-v0.46.11-release-x Nov 16, 2023
26 of 31 checks passed
@drklee3 drklee3 deleted the dl-ledger-cosmos-go-v0.13.1 branch November 16, 2023 18:03
nddeluca pushed a commit that referenced this pull request Jan 9, 2024
@drklee3 @nddeluca
Update ledger-cosmos-go to v0.13.1, hard-code amino json signing only (…
359bc82 
…#534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuairahrighairidh rhuairahrighairidh rhuairahrighairidh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drklee3 @rhuairahrighairidh