Fixes #38107 - Booted container images page #11269
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like I can't use the Foreman React Table component due to the expandable rows. That component sticks children inside a
|
ianballou
force-pushed
the
38107-bootc-images-page
branch
from
ef686fc to
d861aea
Compare
sjha4
reviewed
Dec 20, 2024
| const BootedContainerImagesPage = () => { | ||
| const columns = { | ||
| image_name: { | ||
| title: __('Image name'), |
There was a problem hiding this comment.
Can we change this to Bootc - booted image name so it's also easier to figure out the serach query?
There was a problem hiding this comment.
I changed all of the references to image_name to bootc_booted_image like in the API.
|
So we don't forget after the break, the bookmarks controller needs some love on the page to work.. |
ianballou
force-pushed
the
38107-bootc-images-page
branch
2 times, most recently
from
b61d868 to
85536ed
Compare
ianballou
force-pushed
the
38107-bootc-images-page
branch
from
85536ed to
7ac103d
Compare
|
Sorting support is in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds the "Booted container images" page. In the future it'll likely change to be the "Containers" page and merge with the new container images UI.
Within the page, there is a table that shows an overview of booted container images used by bootc hosts. The table shows the image name, number of digests within, and the number of hosts using that container image:
The last functionality-TODO is to make the rows expand and show the actual digests within. I also need to write tests.
Considerations taken when implementing this change?
I decided to use the newer TableIndexPage from Foreman since it's the new goodness.
This PR is built on top of #11257.
What are the testing steps for this pull request?