Fixes #37145 - Ruby 3 support #10885
Conversation
| @@ -49,7 +49,7 @@ Gem::Specification.new do |gem| | |||
|
|
|||
| # Pulp | |||
| gem.add_dependency "anemone" | |||
|
|
|||
| gem.add_dependency "webrick" | |||
There was a problem hiding this comment.
In running a test build on EL9/Ruby 3, (https://download.copr.fedorainfracloud.org/results/@theforeman/katello-nightly-staging-scratch-73818885-106f-5885-9ea9-0a7072eddbe2/rhel-9-x86_64/07004419-rubygem-katello/builder-live.log.gz), I saw this error and wondered if that is what is being fixed here?
+ /usr/bin/rake 'plugin:assets:precompile[katello]' RAILS_ENV=production DATABASE_URL=nulldb://nohost --trace
Log file /builddir/build/BUILD/katello-4.12.0.pre.master/usr/share/foreman/log/production.log cannot be opened. Falling back to STDOUT
Gem loading error: cannot load such file -- webrick/cookie
There was a problem hiding this comment.
I propose to get rid of anemone: https://projects.theforeman.org/issues/37159
There was a problem hiding this comment.
If we merge this, perhaps add a note above it why we need it?
ofedoren
force-pushed
the
ruby3-min
branch
3 times, most recently
from
4bcb9de to
15866fb
Compare
katello.gemspec
Outdated
| @@ -13,7 +13,7 @@ Gem::Specification.new do |gem| | |||
| gem.homepage = "http://www.katello.org" | |||
| gem.summary = "Content and Subscription Management plugin for Foreman" | |||
| gem.description = "Katello adds Content and Subscription Management to Foreman. For this it relies on Candlepin and Pulp." | |||
| gem.required_ruby_version = '~> 2.5' | |||
| gem.required_ruby_version = '>= 2.7' | |||
There was a problem hiding this comment.
Should this get an upper bound? In https://github.com/Katello/katello/pull/10861/files#diff-21cb8426e694930953a1fb66d2f1e4c0c4021bcadd760d9582423094a4dcaaceR16 you specificed < 3.1, in other plugins we used < 4.
|
An EL9 box with this PR and theforeman/foreman-tasks#743 applied (via packit) passes all bats tests \o/ |
|
/packit build |
|
Account evgeni has no write access nor is author of PR! |
|
/packit build |
|
|
What are the changes introduced in this pull request?
This is a POC as an alternative to #10861.
Considerations taken when implementing this change?
This PR tries to make Katello work on Ruby 3 with minimal changes in Katello, foreman-tasks and Dynflow.
Requires only theforeman/foreman-tasks#743 for now.
What are the testing steps for this pull request?
Run CI and hope for the best.